-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]Avoid Floating point exception (core dumped) when using RedisTable by empty ids inputs. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFHeka
changed the title
Compatible with the optimizers inited from tf.keras.optimizers
[fix]Compatible with the optimizers inited from tf.keras.optimizers
Jan 6, 2022
I proposed an issue: tensorflow/tensorflow#53686 |
MoFHeka
changed the title
[fix]Compatible with the optimizers inited from tf.keras.optimizers
[fix]Avoid Floating point exception (core dumped) when using RedisTable by empty ids inputs.
Jan 7, 2022
rhdong
reviewed
Jan 7, 2022
tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_optimizer.py
Show resolved
Hide resolved
rhdong
reviewed
Jan 7, 2022
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/redis_table_op.cc
Show resolved
Hide resolved
MoFHeka
force-pushed
the
redis-dev
branch
12 times, most recently
from
January 13, 2022 19:01
40ae65f
to
3687340
Compare
rhdong
reviewed
Jan 16, 2022
...rflow_recommenders_addons/dynamic_embedding/python/kernel_tests/redis_table_variable_test.py
Show resolved
Hide resolved
rhdong
reviewed
Jan 16, 2022
configure.py
Outdated
def _VALID_BAZEL_VERSION(tf_version): | ||
if tf_version < "2.0.0": | ||
logging.warn( | ||
"TensorFlow under version 2.0.0 is only limited because its Bazel version, and requires users to make some Bazel script changes from the previous COMMIT to compile properly." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is too long , make it multi-lines.
rhdong
reviewed
Jan 16, 2022
Avoid Floating point exception (core dumped) when using RedisTable by empty ids inputs. Fix bug that crc32c_hash function may underflow.
Add TF2.7.0 CI. Add CUDA_COMPUTE_CAPABILITIES. Remove Python 3.6 in CI.
Tensorflow2.7 requires C++14 or above, changing the standard for CUDA compilation from C++11 to C++14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid Floating point exception (core dumped) when using RedisTable by empty ids inputs. I'm ignoring that and that's what's going to happen dividing by zero.
Also make compatible with the optimizers inited from tf.keras.optimizers. Optimizers call from tf.keras.optimizers are not belong to the class optimizer_v2.OptimizerV2 when using tf2.6.
Add TF2.7.0 CI.
Add CUDA_COMPUTE_CAPABILITIES.
Delete Python 3.6 in CI.
Make compatible with TF2.7 in reduction_ops_impl.h
Tensorflow2.7 requires C++14 or above, changing the standard for CUDA compilation from C++11 to C++14.
Type of change
Checklist:
How Has This Been Tested?
About RedisTable
The printing output will be looked like this
About optimizer
When using optimizer like this would not raise a error.