[Doc]Add Apple Silicon installation instruction & fix typo #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
reviewed
Mar 28, 2022
README.md
Outdated
| **TFRA** Apple Silicon (M1) version requires: | ||
|
|
||
| - macOS 12.0.0+ | ||
| - Python 3.9 |
There was a problem hiding this comment.
We should provide release for py3.8, because tensorflow-macos has py38 and py39 release: https://pypi.org/project/tensorflow-macos/2.5.0/#files
There was a problem hiding this comment.
Added Python 3.8, but I need to test the TFRA build with Python 3.8 first. The testing may take 1-2 days.
rhdong
reviewed
Mar 28, 2022
README.md
Outdated
| @@ -169,8 +169,48 @@ bazel build --enable_runfiles build_pip_pkg | |||
| TF_NEED_CUDA=1 bazel-bin/build_pip_pkg artifacts | |||
| pip install artifacts/tensorflow_recommenders_addons_gpu-*.whl | |||
| ``` | |||
| ##### Apple Silicon Support | |||
| **TFRA** Apple Silicon (M1) version requires: | |||
There was a problem hiding this comment.
Changed to "Requirements:".
rhdong
reviewed
Mar 28, 2022
rhdong
reviewed
Mar 28, 2022
rhdong
reviewed
Mar 28, 2022
rhdong
reviewed
Mar 28, 2022
rhdong
changed the title
|
Adding a referring link at the near top would be better, such as: https://github.com/tensorflow/recommenders-addons/pull/228/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R79 for example; For Apple silicon(M1), please refer to Apple Silicon Support. ---Please be noticed this link should be modified to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Apple Silicon Installation instruction in README.md
Fixed a few typos
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
Run the commands in the terminal