Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] add HMACCUM redis module and enable BPV2 in redis impl #234

Merged
merged 1 commit into from
May 9, 2022
Merged

[Feat] add HMACCUM redis module and enable BPV2 in redis impl #234

merged 1 commit into from
May 9, 2022

Conversation

thorneliu
Copy link
Contributor

@thorneliu thorneliu commented Apr 1, 2022 •
edited

Description

new redis module to add HMACCUM comand to enable bp_v2 in redis backend

Brief Description of the PR:

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

pytest case test_variable_find_with_exists_and_accum

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

  • start a redis server
  • upsert cert KV pairs
  • remove/add some Keys
  • run accum and check K,V contents

@thorneliu thorneliu requested a review from rhdong as a code owner April 1, 2022 14:54
@google-cla
Copy link

google-cla bot commented Apr 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@rhdong rhdong changed the title add HMACCUM redis module and enable BPV2 in redis impl [Feat] add HMACCUM redis module and enable BPV2 in redis impl Apr 2, 2022
@thorneliu thorneliu requested a review from MoFHeka April 6, 2022 13:54
MoFHeka
MoFHeka previously approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@MoFHeka MoFHeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thorneliu
thorneliu commented May 8, 2022
View reviewed changes
Copy link
Contributor Author

@thorneliu thorneliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added copyright headers

third_party/redis_module/avx.h Show resolved Hide resolved
rhdong
rhdong approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MoFHeka
MoFHeka approved these changes May 8, 2022
View reviewed changes
Copy link
Contributor

@MoFHeka MoFHeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit b02d738 into tensorflow:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

@MoFHeka MoFHeka MoFHeka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thorneliu @rhdong @MoFHeka