Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add int64-int64 key-value in combination on GPU. #240

Merged
merged 1 commit into from
May 6, 2022
Merged

Add int64-int64 key-value in combination on GPU. #240

merged 1 commit into from
May 6, 2022

Conversation

Lifann
Copy link
Member

@Lifann Lifann commented May 5, 2022

Description

Brief Description of the PR:

Add int64-int64 key-value types for hashtable on GPU.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • [ x ] Additional Testing
  • [ x ] New Feature

Checklist:

  • [ x ] I've properly formatted my code according to the guidelines
    • [ x ] By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • [ x ] I have added tests that prove my fix is effective or that my feature works

@Lifann Lifann requested a review from rhdong as a code owner May 5, 2022 20:46
rhdong
rhdong approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit c2e897d into tensorflow:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lifann @rhdong