Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix bug that user self-defined variable name would be modified to "TrainableWrapper" when Keras eager mode. #275

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

MoFHeka
Copy link
Contributor

@MoFHeka MoFHeka commented Sep 20, 2022

Description

Fix bug that user self-defined variable name would be modified to "TrainableWrapperHandle" when Keras eager mode. Which code is copied from Tensorflow.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

when using BasicEmbedding in TFRA

…to "TrainableWrapper" when Keras eager mode. Which code is copied from Tensorflow
Copy link
Member

@Lifann Lifann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit da0341c into tensorflow:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants