[fix] fix device of table shard was lost in savedmodel pb file when save model with keras api. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
reviewed
Nov 1, 2022
tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_variable.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Nov 1, 2022
tensorflow_recommenders_addons/dynamic_embedding/python/keras/layers/embedding_test.py
Show resolved
Hide resolved
rhdong
reviewed
Nov 1, 2022
tensorflow_recommenders_addons/dynamic_embedding/python/keras/layers/embedding_test.py
Show resolved
Hide resolved
…ave model with keras api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix device of table shard was lost in savedmodel pb file when save model with keras api. When use keras model saving, there is no device property in TFRA table resource node. So that, it would cause problem in serving scenes when load model with TF C++ api. That is when user want a CPU table but it was treated to a GPU table without enough device memory.
Type of change
Checklist:
How Has This Been Tested?
In file 'tensorflow_recommenders_addons/dynamic_embedding/python/keras/layers/embedding_test.py', a new test function
'test_keras_save_load_weights'.