Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove redundant code #294

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

WangShengguang
Copy link
Contributor

@WangShengguang WangShengguang commented Dec 20, 2022

Description

Remove redundant code

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@google-cla
Copy link

google-cla bot commented Dec 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Member

rhdong commented Dec 20, 2022

Hi @WangShengguang, thank you for your first contribution, you may need to sign the CLA by following the guide of #294 (comment)

@WangShengguang
Copy link
Contributor Author

Hi @WangShengguang, thank you for your first contribution, you may need to sign the CLA by following the guide of #294 (comment)

done

@rhdong
Copy link
Member

rhdong commented Dec 27, 2022

Hi @WangShengguang , it's strange for fail on some MacOS scenarios: https://github.com/tensorflow/recommenders-addons/actions/runs/3737315843/jobs/6435077663#step:7:4974 . Maybe we can check it together, I have set up a baseline PR for comparison; let's keep watch on it: #297

---Update: I found it should be a bug of numpy==1.24.x, I will avoid it by a new PR. You can ignore it firstly, after my PR I will merge yours. Thank you!

@rhdong rhdong merged commit 467bd6c into tensorflow:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants