Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reverse update logic within bp_v2 #306

Merged
merged 1 commit into from
Mar 11, 2023
Merged

fix: Reverse update logic within bp_v2 #306

merged 1 commit into from
Mar 11, 2023

Conversation

Lifann
Copy link
Member

@Lifann Lifann commented Mar 10, 2023 •
edited by rhdong

Description

Brief Description of the PR:

Fixes # (issue)

Fix logic of updating TrainableWrapper with bp_v2 option

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • [ x ] I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@Lifann Lifann requested a review from rhdong as a code owner March 10, 2023 07:37
rhdong
rhdong approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit ec55652 into tensorflow:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lifann @rhdong