Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add unique to keras.layers.BasicEmbedding #309

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[Feat] Add unique to keras.layers.BasicEmbedding #309

merged 1 commit into from
Mar 23, 2023

Conversation

rhdong
Copy link
Member

@rhdong rhdong commented Mar 23, 2023

  • Add unique operation to keras.layers.BasicEmbedding
  • Add keras.layers.Embedding as the alias of keras.layers.BasicEmbedding

@rhdong rhdong requested review from MoFHeka and Lifann March 23, 2023 05:23
@rhdong
Copy link
Member Author

rhdong commented Mar 23, 2023

Hi @MoFHeka , @Lifann , please help review this PR, thank you~

MoFHeka
MoFHeka approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@MoFHeka MoFHeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit dcc3497 into tensorflow:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoFHeka MoFHeka MoFHeka approved these changes

@Lifann Lifann Awaiting requested review from Lifann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhdong @MoFHeka