Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Compatible with TensorFlow 2.13 and below. Also fix some HKV feature. #378

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

MoFHeka
Copy link
Contributor

@MoFHeka MoFHeka commented Jan 30, 2024

Description

[feat] Competible with TF 2.13 by adding new absl status error type. Also adapt to the new TF python level api.
[fix] Rename DECheckpoint and de_save_model api to make them more looks like TF style.
[fix] get_temp_dir function may return different directory. And filesystem may be slower than files asserting check.
[feat] Add bfloat16 value type support to the HKV for being enhanced by Ampere GPU BF16 training feature.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

run old test

@MoFHeka MoFHeka requested a review from rhdong as a code owner January 30, 2024 19:04
@MoFHeka MoFHeka changed the title [Feature] Compatible with TensorFlow 2.13 and below. [Feature] Compatible with TensorFlow 2.13 and below. Also fix some HKV feature. Jan 31, 2024
…vironment withou GPU.

Should not skip any Test when it ran successfully.
Also adapt to the new TF python level api.

In particular, HKV is also compatible with TF2.10/2.11.
And filesystem may be slower than files asserting check.
@rhdong
Copy link
Member

rhdong commented Feb 5, 2024

Hi @MoFHeka, great work. I think It's time to switch the tf version to 2.11.1+2.13.1. You can refer to this PR #284. The specific timing depends on you. It is recommended to join this PR so that you can test your modifications. Thank you!

Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 42ad7d2 into tensorflow:master Feb 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants