Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Compatible with TensorFlow 2.15 #386

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Conversation

MoFHeka
Copy link
Contributor

@MoFHeka MoFHeka commented Feb 28, 2024

Description

Brief Description of the PR:

  • Be compatible with TensorFlow 2.15 by calling the origin python function from new directory.
  • Fix some test should not be run when eager mode. Also add more new test for Redis KV backend.
  • Fix Redis backend json config file would not printed when a wrong json value type was set.
  • Fix check wrong array index in kvs_reply from Redis returning. Wanted to check the length of value, but the length of key was checked.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Run all test script under TF2.15 environment.

@MoFHeka MoFHeka requested a review from rhdong as a code owner February 28, 2024 16:09
@MoFHeka MoFHeka force-pushed the master-dev branch 3 times, most recently from cc02b35 to d32aff1 Compare February 29, 2024 06:41
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Member

rhdong commented Feb 29, 2024

Hi @MoFHeka, we need a separate PR for switching the TF version in the CI and release.

@rhdong rhdong merged commit 095db80 into tensorflow:master Feb 29, 2024
39 checks passed
@jq
Copy link
Collaborator

jq commented Mar 1, 2024

👍🏻 when will we have this release to https://pypi.org/project/tensorflow-recommenders-addons/0.6.0/ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants