[Feat] Try to compatible with Keras 3 optimizer design and support CUDNN 9.0+. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poinwater
reviewed
Mar 20, 2024
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/dynamic_partition_op_gpu.cu.cc
Outdated
Show resolved
Hide resolved
poinwater
reviewed
Mar 20, 2024
jq
reviewed
Mar 20, 2024
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/dynamic_partition_op_gpu.cu.cc
Outdated
Show resolved
Hide resolved
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/lookup_impl/lookup_table_op_hkv.h
Show resolved
Hide resolved
tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_optimizer.py
Show resolved
Hide resolved
MoFHeka
force-pushed
the
master-dev
branch
2 times, most recently
from
1dfe98f
to
ceaedd3
Compare
rhdong
reviewed
Mar 22, 2024
tensorflow_recommenders_addons/dynamic_embedding/core/utils/utils.h
Outdated
Show resolved
Hide resolved
Now support CUDNN 9.0+
by adding a new LOG_IF_ERROR macro and using proper api function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compatibility updates and some compiling log optimizations have been made.
[feat] Competible with Keras3 optimizer style.
[fix] Suppress nodiscard warnings and unused warnings by adding a new LOG_IF_ERROR macro and using proper api function.
[feat] Update the config file for new CUDNN release. Now support CUDNN 9.0+
[fix] self.params may not with saveable attribution.
Type of change
Checklist:
How Has This Been Tested?
use default keras.optimizers in Keras 2.12+ instead of keras.legacy.optimizers.