[CICD] update dev container #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq
previously approved these changes
Apr 27, 2024
| @@ -182,9 +182,9 @@ export CUDNN_INSTALL_PATH="/usr/lib/x86_64-linux-gnu" | |||
| python configure.py | |||
| ``` | |||
| And then build the pip package and install: | |||
| ```sh | |||
| ```sh` | |||
rhdong
force-pushed
the
rhdong/dev-container
branch
from
b75a299
to
e972fcb
Compare
rhdong
commented
Apr 28, 2024
|
|
||
| COPY tools/docker/install/install_nccl.sh /install/ | ||
| RUN /install/install_nccl.sh "2.8.4-1+cuda11.2" | ||
| COPY tools/install_deps/clang-format.sh ./clang-format.sh |
There was a problem hiding this comment.
Hi @jq , just updated to add this clang-format installation, may you have time to review and approve it? Thanks!
jq
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.