[feature]support ragged tensor in all2all #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq
force-pushed
the
ragged_fix
branch
2 times, most recently
from
f4bb954
to
c0a0e38
Compare
jq
force-pushed
the
ragged_fix
branch
18 times, most recently
from
090c093
to
f44f0fd
Compare
rhdong
reviewed
Jun 13, 2024
| # ... | ||
|
|
||
| def _get_processor(v): | ||
| """The processor of v.""" | ||
| # ... | ||
| if isinstance(v, resource_variable_ops.TrainableWrapper): | ||
| if isinstance(v, tensorflow_recommenders_addons.dynamic_embedding.python.ops.embedding_variable.TrainableWrapper): |
There was a problem hiding this comment.
I have no more concerns except the naming here @jq
jq
force-pushed
the
ragged_fix
branch
4 times, most recently
from
d130050
to
4157f74
Compare
jq
force-pushed
the
ragged_fix
branch
3 times, most recently
from
3e981d4
to
f6d09a6
Compare
jq
force-pushed
the
ragged_fix
branch
3 times, most recently
from
8fe1de1
to
26c6ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support ragged tensor in all2all HvdAllToAllEmbedding lookup
refactor embedding variable, introduce embedding_weights interface so that dynamic embedding variable, shadow variable, hvd variable can be easily supported in the lookup and safe_embedding_lookup_sparse
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*