Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc-fix] wrap the optimizer in tfra.dynamic_embedding.DynamicEmbeddingOptimizer #43

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

funsimple
Copy link
Contributor

Description

Brief Description of the PR:
wrap the optimizer in tfra.dynamic_embedding.DynamicEmbeddingOptimizer

Fixes # 41 Bug: Dynamic embedding is not included in model.trainable_variables.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Recommenders Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rhdong rhdong changed the title [fix] wrap the optimizer in tfra.dynamic_embedding.DynamicEmbeddingOptimizer [doc-fix] wrap the optimizer in tfra.dynamic_embedding.DynamicEmbeddingOptimizer Apr 10, 2021
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants