For LaunchTensorsInsert, num_worker_threads is used only when TFRA_NUM_WORKER_THREADS_FOR_LOOKUP_TABLE_INSERT env var is set to k, where k>0 and k<tf current number of cpu worker threads. Otherwise, nothing will change. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
reviewed
Apr 22, 2021
| int64* value); | ||
| } // namespace tensorflow | ||
|
|
||
| #endif // TENSORFLOW_CORE_KERNELS_UTIL_ENV_VAR_H_ |
There was a problem hiding this comment.
add new line at the end of the file.
There was a problem hiding this comment.
Delete the file, rely on the TensorFlow library
| @@ -106,9 +107,27 @@ struct LaunchTensorsInsert<CPUDevice, K, V, J> { | |||
| } | |||
| }; | |||
| auto& worker_threads = *context->device()->tensorflow_cpu_worker_threads(); | |||
| // Only use num_worker_threads when | |||
| // TF_NUM_WORKER_THREADS_FOR_LOOKUP_TABLE_INSERT env var is set to k where k | |||
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/cuckoo_hashtable_op.cc
Show resolved
Hide resolved
| #include "tensorflow/core/platform/str_util.h" | ||
| #include "tensorflow/core/platform/strcat.h" | ||
|
|
||
| namespace tensorflow { |
There was a problem hiding this comment.
Maybe we need a special internal namespace , recommenders_addons ?
There was a problem hiding this comment.
Delete the file, rely on the TensorFlow library
Mr-Nineteen
changed the title
rhdong
reviewed
Apr 22, 2021
| << "Error parsing TFRA_NUM_WORKER_THREADS_FOR_LOOKUP_TABLE_INSERT: " | ||
| << status; | ||
| } | ||
| if (num_worker_threads < 0 || |
There was a problem hiding this comment.
TFRA_NUM_WORKER_THREADS_FOR_LOOKUP_TABLE_INSERT=0， num_worker_threads will keep zero..
…WORKER_THREADS_FOR_LOOKUP_TABLE_INSERT env var is set to k, where k>0 and k<tf current number of cpu worker threads. Otherwise, nothing will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LaunchTensorsInsert, num_worker_threads is used only when TFRA_NUM_WORKER_THREADS_FOR_LOOKUP_TABLE_INSERT env var is set to k, where k>0 and k<tf current number of cpu worker threads. Otherwise, nothing will change.