[opt] reduce memory consuming of de.Variable and support string type Keys and Values. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rhdong
commented
Apr 23, 2021
•
rhdong
commented
- reduce memory consuming of de.Variable
- support string type Keys and Values.
- switch the hash function to murmur hash when Key type is int64.
rhdong
force-pushed
the
rhdong/dev
branch
2 times, most recently
from
f2be805
to
ac6a6cb
Compare
Mr-Nineteen
reviewed
Apr 23, 2021
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/lookup_impl/lookup_table_op_cpu.h
Outdated
Show resolved
Hide resolved
|
LGTM |
rhdong
added a commit
to rhdong/recommenders-addons
that referenced
this pull request
Apr 28, 2021
missing commit for the PR: tensorflow#57
rhdong
added a commit
to rhdong/recommenders-addons
that referenced
this pull request
Apr 28, 2021
missing commit for the PR: tensorflow#57
rhdong
added a commit
to rhdong/recommenders-addons
that referenced
this pull request
Apr 28, 2021
missing commit for the PR: tensorflow#57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.