Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api_docs for dynamic_embedding #82

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Update api_docs for dynamic_embedding #82

merged 1 commit into from
Jun 1, 2021

Conversation

Lifann
Copy link
Member

@Lifann Lifann commented May 24, 2021

Update api_docs for dynamic_embedding

@rhdong
Copy link
Member

rhdong commented May 24, 2021

it's duplicated for ：
tfra.dynamic_embedding.safe_embedding_lookup_sparse
tfra.dynamic_embedding.python.ops.safe_embedding_lookup_sparse

@Lifann
Copy link
Member Author

Lifann commented May 25, 2021

it's duplicated for ：
tfra.dynamic_embedding.safe_embedding_lookup_sparse
tfra.dynamic_embedding.python.ops.safe_embedding_lookup_sparse

I've removed the duplicated APIs, and dropped the dynamic_embedding.python.xxx.

@Lifann Lifann requested a review from rhdong as a code owner May 25, 2021 13:17
@rhdong
Copy link
Member

rhdong commented Jun 1, 2021

LGTM

@rhdong rhdong merged commit b0e4e9f into tensorflow:master Jun 1, 2021
@Lifann Lifann deleted the Lifann/add-api-docs branch June 18, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong Awaiting requested review from rhdong rhdong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lifann @rhdong