[feat] compatible with TF1.15.2 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Nineteen
reviewed
Jun 2, 2021
Mr-Nineteen
reviewed
Jun 2, 2021
Mr-Nineteen
reviewed
Jun 2, 2021
Mr-Nineteen
reviewed
Jun 2, 2021
Mr-Nineteen
reviewed
Jun 2, 2021
rhdong
commented
Jun 2, 2021
| RUN rm /usr/bin/gcc | ||
| ENV PATH=/dt7/usr/bin${PATH:+:${PATH}} | ||
| # Use devtoolset-7 as tool chain | ||
| RUN rm -r /usr/bin/gcc* |
There was a problem hiding this comment.
@zhangyafeikimi Pls help check it, I have force remove the gcc* in /usr/bin/ and use devtoolset-7.
Mr-Nineteen
reviewed
Jun 2, 2021
Mr-Nineteen
reviewed
Jun 2, 2021
Mr-Nineteen
reviewed
Jun 2, 2021
rhdong
force-pushed
the
rhdong/compatible-with-tf1152
branch
4 times, most recently
from
e8a5bfa
to
7def57c
Compare
Lifann
reviewed
Jun 3, 2021
tensorflow_recommenders_addons/dynamic_embedding/core/kernels/cuckoo_hashtable_op.cc
Show resolved
Hide resolved
Lifann
reviewed
Jun 3, 2021
| @@ -56,6 +56,8 @@ TF_CALL_int8(REGISTER_KERNELS); | |||
| TF_CALL_int32(REGISTER_KERNELS); | |||
| TF_CALL_half(REGISTER_KERNELS); | |||
| TF_CALL_float(REGISTER_KERNELS); | |||
| TF_CALL_tstring(REGISTER_KERNELS); | |||
There was a problem hiding this comment.
It seems that the corresponding functor has not been defined to support tstring.
Lifann
reviewed
Jun 3, 2021
tensorflow_recommenders_addons/dynamic_embedding/core/utils/utils.h
Outdated
Show resolved
Hide resolved
rhdong
force-pushed
the
rhdong/compatible-with-tf1152
branch
from
651a160
to
52eef53
Compare
|
No need for them, the decorate macro is created for history reason, we had to compatible with TF1.x naming rule which doesn't support the "XYZ>AbcEfg" rule, but we cann't change the name directly for some user already use TFRA release 1 in product environment, and change name to "TfraXyz" may cause compatible problem. For new OPs, we will not use ">" at first. |
Lifann
reviewed
Jun 3, 2021
rhdong
force-pushed
the
rhdong/compatible-with-tf1152
branch
2 times, most recently
from
a9e8858
to
748aab9
Compare
- compatible with TF1.15.2 - add CI docker files - Add TF1152 to workflow - change bazel version to 3.1.0 - remove TF from requirement.txt and make it setup by code - Update README.md - change GPU compute Capability to 60/70/75/80
rhdong
force-pushed
the
rhdong/compatible-with-tf1152
branch
from
748aab9
to
fe8538a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes: