Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release scann compiled against Tensorflow 2.12 #671

Closed
IzakMaraisTAL opened this issue May 31, 2023 · 2 comments
Closed

Please release scann compiled against Tensorflow 2.12 #671

IzakMaraisTAL opened this issue May 31, 2023 · 2 comments

Comments

@IzakMaraisTAL
Copy link

Apologies for the cross post from google-research/google-research#1594, but:

  • there has been no comment on that issue in the google-research repo
  • ScaNN is accessed via tensorflow_recommenders.layers.factorized_top_k.ScaNN(), so perhaps I should have posted here in the first place?

The latest release (1.2.9) of scann is compiled against Tensorflow 2.11.

I want to use scann with TFX. The latest TFX release (1.13.0) requires Tensorflow >=2.12.0. This makes it impossible to use scann with TFX 1.13.0.

TFX 1.13.0 is also the first one to ship a docker image with python > 3.7. Since python 3.7 security support ends 27 June, I really want to use latest TFX docker image, but my project requires that I also install scann.

@IzakMaraisTAL
Copy link
Author

IzakMaraisTAL commented Jul 19, 2023

Python 3.7 is now past end of life, so we would like to move on to the 3.9 based TFX 1.13 Docker image.

Also, tensorflow/tfx#5777 (comment) requests that I test a bug fix with TFX 1.13, but this issue is blocking that test.

@IzakMaraisTAL
Copy link
Author

A new release of scann is available which targets tensorflow 2.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant