Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-valgrind #89

Merged
merged 1 commit into from
Jul 29, 2017
Merged

Add run-valgrind #89

merged 1 commit into from
Jul 29, 2017

Conversation

adamcrume
Copy link
Contributor

This partially addresses #69, but it requires us to build TensorFlow from source, which is too slow to do on Travis.

@Enet4
Copy link
Contributor

Enet4 commented Jun 18, 2017

It sounds like this modified version of TensorFlow is something worth caching, either on Travis itself or somewhere else.

@adamcrume
Copy link
Contributor Author

Caching on Travis won't work, because TensorFlow takes too long to build in the first place. Someone would have to manually build it and store it somewhere as part of upgrading the version of TensorFlow that we depend on. @asimshankar, would we be able to use storage.googleapis.com/tensorflow for storing builds of TensorFlow with jemalloc disabled, or would we need a separate project?

@asimshankar
Copy link
Contributor

I don't think the TensorFlow maintainers have the bandwidth to regularly build binary artifacts both with and without jemalloc, so probably best to host the non-jemalloc artifacts somewhere else.

Though @jhseu might be in a better position to comment

@adamcrume
Copy link
Contributor Author

Sorry for the confusion -- I wasn't suggesting that the TensorFlow maintainers build binaries with jemalloc disabled; I was just asking if we could piggy-back on their storage space.

@jhseu
Copy link

jhseu commented Jun 20, 2017

Sorry, we've been locking down the tensorflow GCS bucket so that only those who require access to perform releases can use it. I'm also not aware of a good alternative GCS location we have for this kind of purpose.

This partially addresses tensorflow#69, but it requires us to build TensorFlow from source, which is too slow to do on Travis.
@adamcrume
Copy link
Contributor Author

I fixed a few bugs in the script. I'll go ahead and merge this because a manually-run check is better than no check at all, but I'll leave #69 open.

@adamcrume adamcrume merged commit 82193ac into tensorflow:master Jul 29, 2017
ramon-garcia pushed a commit to ramon-garcia/tensorflow-rust that referenced this pull request May 20, 2023
* tensorflow#89 Remove fold/sheet limits so a full dataset can be output, albeit still limited by DisplayMinWidth/column concatenation at header width

* Update Readme with arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants