Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed deprecated dependency tensorflow-gpu #2096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorflow_serving/tools/docker/Dockerfile.devel-gpu
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ RUN bazel build --color=yes --curses=yes \
bazel-bin/tensorflow_serving/tools/pip_package/build_pip_package \
/tmp/pip && \
pip --no-cache-dir install --upgrade \
/tmp/pip/tensorflow_serving_api_gpu-*.whl && \
/tmp/pip/tensorflow_serving_api-*.whl && \
rm -rf /tmp/pip

FROM binary_build as clean_build
Expand Down
8 changes: 2 additions & 6 deletions tensorflow_serving/tools/pip_package/build_pip_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,8 @@ function main() {
cp ${PIP_SRC_DIR}/setup.py "${TMPDIR}"

pushd "${TMPDIR}"
echo $(date) : "=== Building wheel (CPU)"
python3 setup.py bdist_wheel --universal \
--project_name tensorflow-serving-api # >/dev/null
echo $(date) : "=== Building wheel (GPU)"
python3 setup.py bdist_wheel --universal \
--project_name tensorflow-serving-api-gpu # >/dev/null
echo $(date) : "=== Building wheel"
python3 setup.py bdist_wheel --universal
mkdir -p "${DEST}"
cp dist/* "${DEST}"
popd
Expand Down
12 changes: 0 additions & 12 deletions tensorflow_serving/tools/pip_package/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,9 @@
_TF_VERSION_SANITIZED = _TF_VERSION.replace('-', '')

project_name = 'tensorflow-serving-api'
# Set when building the pip package
if '--project_name' in sys.argv:
project_name_idx = sys.argv.index('--project_name')
project_name = sys.argv[project_name_idx + 1]
sys.argv.remove('--project_name')
sys.argv.pop(project_name_idx)

_TF_REQ = ['tensorflow'+_TF_VERSION_SANITIZED]

# GPU build (note: the only difference is we depend on tensorflow-gpu so
# pip doesn't overwrite it with the CPU build)
if 'tensorflow-serving-api-gpu' in project_name:
_TF_REQ = ['tensorflow-gpu'+_TF_VERSION_SANITIZED]


REQUIRED_PACKAGES = [
# Match versions to what TF needs here:
# https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/pip_package/setup.py
Expand Down