Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexing #314

Merged
merged 36 commits into from
Mar 21, 2023
Merged

Indexing #314

merged 36 commits into from
Mar 21, 2023

Conversation

dnazila
Copy link
Collaborator

@dnazila dnazila commented Feb 27, 2023

Adding linear search, faiss approximate NN lookup, cached store, and redis store

Ali Zand added 3 commits February 27, 2023 13:23
adding linear search, faiss ann search, cached storage, and redis sto…
7dcc147 
…rage. Also refactoring indexer class for easing implementation of indexers that would depend on packages that include both search and storage.
formatting
26dbf15
formatting and fixing couple of issues
e201ac0
@dnazila dnazila self-assigned this Feb 27, 2023
@dnazila dnazila linked an issue Feb 27, 2023 that may be closed by this pull request
Add more indexing and storage capabilities to support larger lookup databases #313
Open
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dnazila dnazila changed the base branch from master to development February 27, 2023 22:32
@dnazila dnazila marked this pull request as ready for review March 2, 2023 03:54
@ebursztein
Copy link
Member

Looks promising but there are quite a few types, documentation and else branch with error values missing.
Also I didn't see a notebook that helps understand how to use the various storage -- seems important.
last but not least the Readme needs to be updated to discuss backend storage.

owenvallis
owenvallis reviewed Mar 12, 2023
View reviewed changes
setup.py Show resolved Hide resolved
owenvallis
owenvallis requested changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@owenvallis owenvallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added some comments on few files but mostly small things here and there

tensorflow_similarity/base_indexer.py Outdated Show resolved Hide resolved
tensorflow_similarity/base_indexer.py Show resolved Hide resolved
tensorflow_similarity/base_indexer.py Outdated Show resolved Hide resolved
tensorflow_similarity/base_indexer.py Outdated Show resolved Hide resolved
tensorflow_similarity/base_indexer.py Show resolved Hide resolved
tensorflow_similarity/search/linear_search.py Show resolved Hide resolved
tensorflow_similarity/stores/cached_store.py Outdated Show resolved Hide resolved
tensorflow_similarity/stores/cached_store.py Outdated Show resolved Hide resolved
tensorflow_similarity/stores/memory_store.py Outdated Show resolved Hide resolved
tensorflow_similarity/stores/redis_store.py Outdated Show resolved Hide resolved
@dnazila dnazila requested a review from owenvallis March 20, 2023 22:42
owenvallis
owenvallis approved these changes Mar 20, 2023
View reviewed changes
tensorflow_similarity/indexer.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@dnazila dnazila merged commit 681e189 into development Mar 21, 2023
@dnazila dnazila deleted the indexing branch March 21, 2023 04:51
abeltheo pushed a commit to abeltheo/similarity that referenced this pull request Mar 23, 2023
@dnazila
Merge pull request tensorflow#314 from tensorflow/indexing
9923cdb 
Indexing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvallis owenvallis owenvallis approved these changes

Assignees

@dnazila dnazila

Labels
component:indexing type:feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more indexing and storage capabilities to support larger lookup databases
3 participants
@dnazila @ebursztein @owenvallis