This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
build: add a hard dependency on PythonKit with SPM #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike CMake, SPM does not permit any control over build configuration. Make PythonKit a hard dependency for the package. This along with the remainder of the changes that have been made to the build system now enable building Swift APIs with SPM in a complete configuration of PythonKit + Swift Numerics + X10. This simplifies the path towards getting a SPM built Swift APIs with X10 and PythonKit support with a standard toolchain.
pschuh
approved these changes
Dec 15, 2020
BradLarson
approved these changes
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike CMake, SPM does not permit any control over build configuration.
Make PythonKit a hard dependency for the package. This along with the
remainder of the changes that have been made to the build system now
enable building Swift APIs with SPM in a complete configuration of
PythonKit + Swift Numerics + X10. This simplifies the path towards
getting a SPM built Swift APIs with X10 and PythonKit support with a
standard toolchain.