This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Linear Algebra] Add eye and svd functions #578
[Linear Algebra] Add eye and svd functions #578
Changes from 2 commits
b772d29
fc00fb6
bb15891
9ef5e5b
9c5f3a3
5e10ae0
5410a99
6cffc01
fe4d146
448d5ee
0c7f671
ec799bc
403934f
a4fbd88
9b20d92
eef989b
78a5ea7
7c184bd
336250d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename
computeUv
tocomputeUV
,uv
or something more readable? It might follow the language style, but it is slightly obscure, what is meant bycomputeUv
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I took this variable name from the raw ops generated. I do agree that it sounds sort of vague.
But would like @dan-zheng's idea on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
computeUV
is the better name, sinceUv
is more easily misinterpreted as one camelcased entity thanUV
. Could you please update the parameter name and doc comments?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A semantic name like
computeLeftAndRightSingularVectors
may be more idiomatic thancomputeUV
. I'm not sure what's the best semantic name, so usingcomputeUV
for now sounds good to me, to be consistent withnumpy.svd
andtf.linalg.svd
.