Updated Transformer model to use callable.
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoxzhao
force-pushed
the
lzhao/apply_callable
branch
from
5102756
to
cc6d3b5
Compare
leoxzhao
commented
Apr 19, 2019
| func applied(to input: AttentionInput, state: inout AttentionContext) | ||
| -> Tensor<Float> { | ||
|
|
||
| func call(_ input: AttentionInput, state: inout AttentionContext) -> Tensor<Float> { |
There was a problem hiding this comment.
call functions with state do not have @differentiable. I keep it that way.
Closed
|
Upstream: swiftlang/swift#24157. |
|
swiftlang/swift#24157 has been merged. If you could update it to the callable syntax for the call sites that take an |
rxwei
approved these changes
Apr 20, 2019
…r functions with `inout` parameters.
leoxzhao
force-pushed
the
lzhao/apply_callable
branch
from
cc6d3b5
to
eaae541
Compare
|
Thanks Leo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to use
.callexplicitly for callable withinout. Once "Static callable does not supportinout" (https://bugs.swift.org/browse/TF-443) get fixed, we can simply remove.callin the code.