add top 5 accuracy metric #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettkoonce
force-pushed
the
top5accuracy
branch
from
c79ac9b
to
f664701
Compare
xihui-wu
reviewed
Dec 11, 2020
brettkoonce
force-pushed
the
top5accuracy
branch
from
3dfa909
to
f40f408
Compare
xihui-wu
reviewed
Dec 14, 2020
xihui-wu
reviewed
Dec 15, 2020
TrainingLoop/Metrics.swift
Outdated
Comment on lines
133
to
136
| let topK = _Raw.inTopKV2(predictions: predictions, targets: labels, k: Tensor<Int32>(k)) | ||
| let correctCount = Tensor<Int32>(topK).sum() | ||
| correctGuessCount += Int32(correctCount.scalar ?? 0) | ||
| totalGuessCount += Int32(labels.shape.reduce(1, *)) |
There was a problem hiding this comment.
This should break GPT2-WikiText2. We may want to make the predictions and labels to the conforming shape before calling inTopKV2. Can you try the following and run test swift run -c release GPT2-Wiki2Text2 ?
let predictionsReshaped = predictions.reshaped(
to: [predictions.shape.dropLast().reduce(1, *), predictions.shape.last!])
let labelsReshaped = labels.reshaped(to: [labels.shape.reduce(1, *)])
correctGuessCount += Int32(
Tensor<Int32>(
_Raw.inTopKV2(
predictions: predictionsReshaped, targets: labelsReshaped, k: Tensor<Int32>(k))).sum()
.scalar ?? 0)
totalGuessCount += Int32(labelsReshaped)
There was a problem hiding this comment.
@xihui-wu tweaked the last line slightly, works here w/ GPT2-Wiki2Text2 + LeNet-MNIST!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @xihui-wu