Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

corrected Windows installation verification step instructions #430

Merged
merged 4 commits into from Jun 1, 2020

Conversation

maxvol
Copy link
Contributor

@maxvol maxvol commented Apr 25, 2020

corrected Windows installation verification step instructions as discussed here -
#421

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dan-zheng dan-zheng requested a review from compnerd April 25, 2020 03:33
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so we want to have the different paths for Linux, Windows, and macOS? The commands as is do not really work on macOS (when I last tried) but required some extra flags. However, this looks good from the windows side.

@ematejska
Copy link
Contributor

@maxvol Could you please sign the CLA?

@maxvol
Copy link
Contributor Author

maxvol commented May 21, 2020

@maxvol Could you please sign the CLA?

@ematejska done! sorry for delay

@maxvol
Copy link
Contributor Author

maxvol commented May 21, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ematejska
Copy link
Contributor

The page now needs to take into consideration all platforms.

@dabrahams
Copy link
Contributor

@compnerd PTAL. Should we change the prompt character from $ to >?

@compnerd
Copy link
Contributor

compnerd commented Jun 1, 2020

I think that fixing the prompt character can be done in a follow up as it was incorrect before this.

@compnerd
Copy link
Contributor

compnerd commented Jun 1, 2020

Thanks @maxvol for the improvements!

@compnerd compnerd merged commit 2fdf7a0 into tensorflow:master Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants