corrected Windows installation verification step instructions #430
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so we want to have the different paths for Linux, Windows, and macOS? The commands as is do not really work on macOS (when I last tried) but required some extra flags. However, this looks good from the windows side.
@maxvol Could you please sign the CLA? |
@ematejska done! sorry for delay |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
The page now needs to take into consideration all platforms. |
@compnerd PTAL. Should we change the prompt character from |
I think that fixing the prompt character can be done in a follow up as it was incorrect before this. |
Thanks @maxvol for the improvements! |
corrected Windows installation verification step instructions as discussed here -
#421