Skip to content
This repository has been archived by the owner on Jul 7, 2023. It is now read-only.

Absolute Position Encoding:Why are the two tensors not alternately merged? #1925

Closed
davinca opened this issue Apr 28, 2023 · 2 comments
Closed

Comments

@davinca
Copy link

davinca commented Apr 28, 2023

signal = tf.concat([tf.sin(scaled_time), tf.cos(scaled_time)], axis=1)

In the orginal paper, the position_embedding is like this: [..., sin i, cos i, ...]

@martinpopel
Copy link
Contributor

See #177 and #1591 (and #1677).

@davinca davinca closed this as completed Apr 28, 2023
@davinca
Copy link
Author

davinca commented Apr 28, 2023

just different orderings of the same set of channels, The effects of both are consistent theoretically.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants