Skip to content
This repository has been archived by the owner on Jul 7, 2023. It is now read-only.

sovle the issue 1219. When use the translate_enzh_rev problem module, the decoding resulte is wrong. #1389

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

googlehjx
Copy link
Contributor

Error Querying Server: Requested more than 0 entries, but params is empty. #1219
After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.

Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219 After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.
Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219
After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author has not signed CLA label Jan 21, 2019
@googlehjx
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I have signed CLA, thanks.

@googlehjx googlehjx changed the title Googlehjx patch 1 sovle the issue 1219. When use the translate_enzh_rev problem module, the decoding resulte is wrong. Jan 21, 2019
@lukaszkaiser
Copy link
Contributor

Sorry, I don't understand this change. In problems that reverse examples, how comes we should not reverse them? I think this change would break many datasets what work well with reversing. Could we not find out what's the specific thing about this one that fails?

@googlehjx
Copy link
Contributor Author

googlehjx commented Jan 23, 2019

the function serving_input_fn only affects serving process, with no affection about the training and others.

@lukaszkaiser
Copy link
Contributor

Thanks for the explanation, looks good! Could you try again with the CLA? We need it, please either sign in the system or, if that doesn't work, add a separate comment just confirming that you agree. (I know it's just one line, but we have to do this.)

@googlehjx
Copy link
Contributor Author

I agree with that, merging my change to the code repository.

@googlehjx
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels Jan 24, 2019
@afrozenator
Copy link
Contributor

Thanks a lot @googlehjx ! WilL merge this in shortly.

@afrozenator afrozenator merged commit f20ae39 into tensorflow:master Jan 24, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jan 24, 2019
PiperOrigin-RevId: 230774856
kpe pushed a commit to kpe/tensor2tensor that referenced this pull request Mar 2, 2019
… the decoding resulte is wrong. (tensorflow#1389)

* Update problem.py

Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219 After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.

* Update problem.py

Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219
After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.
kpe pushed a commit to kpe/tensor2tensor that referenced this pull request Mar 2, 2019
PiperOrigin-RevId: 230774856
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants