-
Notifications
You must be signed in to change notification settings - Fork 3.4k
sovle the issue 1219. When use the translate_enzh_rev problem module, the decoding resulte is wrong. #1389
Conversation
Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219 After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.
Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219 After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I have signed CLA, thanks. |
Sorry, I don't understand this change. In problems that reverse examples, how comes we should not reverse them? I think this change would break many datasets what work well with reversing. Could we not find out what's the specific thing about this one that fails? |
the function serving_input_fn only affects serving process, with no affection about the training and others. |
Thanks for the explanation, looks good! Could you try again with the CLA? We need it, please either sign in the system or, if that doesn't work, add a separate comment just confirming that you agree. (I know it's just one line, but we have to do this.) |
I agree with that, merging my change to the code repository. |
I signed it! |
CLAs look good, thanks! |
Thanks a lot @googlehjx ! WilL merge this in shortly. |
PiperOrigin-RevId: 230774856
… the decoding resulte is wrong. (tensorflow#1389) * Update problem.py Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219 After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code. * Update problem.py Error Querying Server: Requested more than 0 entries, but params is empty. tensorflow#1219 After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.
PiperOrigin-RevId: 230774856
Error Querying Server: Requested more than 0 entries, but params is empty. #1219
After days of work, I have solved this problem. It caused by the function serving_input_fn. The input example no need to be reversed any more. So I deleted the code.