This repository has been archived by the owner on Jul 7, 2023. It is now read-only.
Replace numerically more stable log1p and expm1 #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces `log(1 + x)` with `log1p(x)` and `exp(x) - 1` with `expm1(x)`. These functions are more precise if x is close to zero.
|
Thanks a lot for these @lgeiger -- they are much appreciated, as always! |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 8, 2019
PiperOrigin-RevId: 233100331
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
This PR replaces `log(1 + x)` with `log1p(x)` and `exp(x) - 1` with `expm1(x)`. These functions are more precise if x is close to zero.
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
PiperOrigin-RevId: 233100331
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
log(1 + x)withlog1p(x)andexp(x) - 1withexpm1(x). These functions are more precise if x is close to zero.