This repository has been archived by the owner on Jul 7, 2023. It is now read-only.
Slightly simplify python loops and attr access #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some minor readability imrpovements that accumulated during debugging bugs in my custom model code.
afrozenator
reviewed
Feb 11, 2019
| for i in range(len(self._id_to_token)): | ||
| f.write(self._id_to_token[i] + "\n") | ||
| for token in self._id_to_token: | ||
| f.write(token + "\n") |
There was a problem hiding this comment.
this will not work, _id_to_token is a dict and the previous code basically writes tghe vocab file in order.
There was a problem hiding this comment.
Good catch. I missed the fact that dicts aren't order prior to Python 3.6.
afrozenator
reviewed
Feb 11, 2019
|
Thanks a lot again for this @lgeiger , I'm merging in now, will do that revert on my end. |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 11, 2019
PiperOrigin-RevId: 233438134
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
Just some minor readability imrpovements that accumulated during debugging bugs in my custom model code.
kpe
pushed a commit
to kpe/tensor2tensor
that referenced
this pull request
Mar 2, 2019
PiperOrigin-RevId: 233438134
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor readability improvements that accumulated during debugging bugs in my custom model code.