This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix plugin_data field assignment.
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `plugin_data` is not a repeated field, it does not have the add() method, and field assignment should instead be done directly.
chihuahua
reviewed
Aug 22, 2017
greeter_plugin/greeter_summary.py
Outdated
| @@ -55,7 +55,8 @@ def op(name, | |||
| summary_metadata = tf.SummaryMetadata() | |||
| # We could put additional metadata other than the PLUGIN_NAME, | |||
| # but we don't need any metadata for this simple example. | |||
| summary_metadata.plugin_data.add(plugin_name=PLUGIN_NAME, content="") | |||
There was a problem hiding this comment.
nit: Could you instead please use
tf.SummaryMetadata(
display_name=display_name,
summary_description=description,
plugin_data=tf.SummaryMetadata.PluginData(
plugin_name=PLUGIN_NAME,
content=""))
and then remove the display_name and summary_description parameters from the call to tf.summary.tensor_summary? Same as the other change below.
There was a problem hiding this comment.
Good idea. I updated it. Let me know if there is anything else I should change.
chihuahua
approved these changes
Aug 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the fields of
plugin_datawith direct assignment instead through a call to add().Calling the add() method raises an error because
plugin_datais no longer a repeated field, as seen in the changes of this commit: tensorflow/tensorflow@4c60c96. Settingplugin_data's field values with direct assignment fixes the issue.