Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: upgrade dependency #4277

Open
3 tasks
stephanwlee opened this issue Nov 5, 2020 · 0 comments
Open
3 tasks

infra: upgrade dependency #4277

stephanwlee opened this issue Nov 5, 2020 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@stephanwlee
Copy link
Contributor

stephanwlee commented Nov 5, 2020 •
edited by wchargin
Loading

TensorBoard should upgrade:

  • Angular, rxjs, ngrx to 9+
  • TypeScript to 4.
  • Bazel to 3.5.0 (needed by Node stack; rules_rust head also wants 3.0.0+)
@stephanwlee stephanwlee added the dependencies Pull requests that update a dependency file label Nov 5, 2020
wchargin added a commit that referenced this issue Nov 10, 2020
@wchargin
workspace: upgrade to newer rules_rust
9351cc0 
Summary:
We pull in bazelbuild/rules_rust#468 to make it easier to build protos,
while not pulling in bazelbuild/rules_rust#463, because that would
require us to update Bazel to 3.0.0. Happily, the commit that we need
merged immediately before the commit that we don’t want! (Yes, this is a
wee bit precarious; we’re working on the Bazel upgrade: #4277.)

Test Plan:
With both Bazel 2.1.0 and Bazel 3.7.0, everything builds, all tests
pass, and TensorBoard looks okay enough.

wchargin-branch: rules-rust-20201105a
wchargin-source: bb3180a3a2a415d800d6a2a925fef0cb4e376d2f
@wchargin wchargin mentioned this issue Nov 10, 2020
Merged
wchargin added a commit that referenced this issue Nov 10, 2020
@wchargin
workspace: upgrade to newer rules_rust (#4307)
ffe1680 
Summary:
We pull in bazelbuild/rules_rust#468 to make it easier to build protos,
while not pulling in bazelbuild/rules_rust#463, because that would
require us to update Bazel to 3.0.0. Happily, the commit that we need
merged immediately before the commit that we don’t want! (Yes, this is a
wee bit precarious; we’re working on the Bazel upgrade: #4277.)

Test Plan:
With both Bazel 2.1.0 and Bazel 3.7.0, everything builds, all tests
pass, and TensorBoard looks okay enough.

wchargin-branch: rules-rust-20201105a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephanwlee