-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RustBoard tasks #4422
Comments
May I reserve plugin listing? |
Sure! You’ll want to update the You can unit test this easily (follow existing examples), and for an |
I’ve grabbed blob sequence support. It’s more involved than tensors but |
I ended up also grabbing “make CRCs optional” because I was curious and |
Introduces a `--samples-per-plugin` flag on the Rust data server, which takes the `--samples_per_plugin` flag from standard TensorBoard's CLI. At the moment, this change makes the value of `0` interpreted as "create a reservoir with capacity 0", while traditionally the value would be interpreted as "create a reservoir with unbounded capacity". This discrepancy will be addressed separately. Test plan: Added unit tests and ran with `cargo test`. Ran `bazel run tensorboard:dev --define=link_data_server=true -- --load_fast --logdir <logdir> --bind_all --samples_per_plugin=scalars=5,images=0` and observed that scalar charts that normally show lots of points now only show 5, while images do not appear at all. Associated issue: "samples per plugin" item in the Rustboard task list #4422.
Feature tasks
If you’re interested, let me know, and I’ll assess whether it’s a good idea and
provide guidance if appropriate.
Small-ish
ListPlugins
RPC #4487)Involved
audio, graphs
ReadBlob
is a server-streaming RPCcrossbeam
for scoped threads and maybeSegQueue
rayon
!in practice
never marks old files as dead
These are mostly for feature parity. There are further ideas for new
features—indexing, deferred blob loading, etc.—but let’s hold off on
those.
Infra tasks
(I plan to take care of these.)
Logdir
trait for other filesystems #4636)main.rs
intorustboard_core::cli
tensorboard
totensorboard-data-server
(pip: depend ontensorboard-data-server
#4676)platforms
Other tasks that I plan to investigate:
rather than actually using the data provider
(see discussion on rust: implement data_compat.rs basic tensor support #4734)
--load_fast
from being fastThe text was updated successfully, but these errors were encountered: