projector: fix broken KNN #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several issues with the code. 1. `Tensor.prototype.transpose` symbol no longer exist. Replaced it with `tf.transpose` instead. 2. KNN reuse was flawed as reused version would return a different number of outputs than what it would return normally. 3. `tf.split` expects all returned members to have the equal size where it previously could not guarantee that. We now pad the matrix so the equal size can be formed even if we discard useless padded elements. In the future, we may want to disable GPU based computation acceleration as it is actually slower than just doing it on CPU.
bmd3k
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several issues with the code.
Tensor.prototype.transposesymbol no longer exist. Replaced it withtf.transposeinstead.number of outputs than what it would return normally.
tf.splitexpects all returned members to have the equal size whereit previously could not guarantee that. We now pad the matrix so the
equal size can be formed even if we discard useless padded elements.
In the future, we may want to disable GPU based computation acceleration
as it is actually slower than just doing it on CPU.