Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projector: fix broken KNN #5063

Merged
merged 3 commits into from
Jun 16, 2021
Merged

projector: fix broken KNN #5063

merged 3 commits into from
Jun 16, 2021

Commits on Jun 15, 2021

  1. projector: fix broken KNN 

    There were several issues with the code.

1. `Tensor.prototype.transpose` symbol no longer exist. Replaced it with
  `tf.transpose` instead.
2. KNN reuse was flawed as reused version would return a different
  number of outputs than what it would return normally.
3. `tf.split` expects all returned members to have the equal size where
it previously could not guarantee that. We now pad the matrix so the
  equal size can be formed even if we discard useless padded elements.

In the future, we may want to disable GPU based computation acceleration
as it is actually slower than just doing it on CPU.
    @stephanwlee
    stephanwlee committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    b3b0eed View commit details
    Browse the repository at this point in the history

  2. fix test

    @stephanwlee
    stephanwlee committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    bac2e05 View commit details
    Browse the repository at this point in the history

  3. remove the test only flag

    @stephanwlee
    stephanwlee committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    8cfde40 View commit details
    Browse the repository at this point in the history