Remove wheel from the requirements in setup.py #6567
Comments
|
This seems like a good idea. I will remove it. |
JamesHollyer
added a commit
that referenced
this issue
Sep 27, 2023
## Motivation for features / changes This package is no longer needed in newer versions of python. It comes as a seed package where needed. It is even causing some users problems(#6567)
JamesHollyer
added a commit
to JamesHollyer/tensorboard
that referenced
this issue
Sep 27, 2023
## Motivation for features / changes This package is no longer needed in newer versions of python. It comes as a seed package where needed. It is even causing some users problems(tensorflow#6567)
|
This dependency should no longer be included as of 2.14.1. |
JamesHollyer
added a commit
that referenced
this issue
Oct 6, 2023
## Motivation for features / changes This package is no longer needed in newer versions of python. It comes as a seed package where needed. It is even causing some users problems(#6567)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can we remove the wheel requirement from the requirements.txt at
tensorboard/tensorboard/pip_package/requirements.txt
Line 36 in eaab3eb
pip installwill automatically install it and for projects depending onpyproject.toml, it can be included as part of build-time dependency.In Apache Beam, we generate our dependencies requirements file and we have tensorflow as a dependency, which has tensorboard as dependency. So we generate our requirements file by installing all the requirements in the virtual env and then doing a pip list. In this way, wheel won't included as part of
pip list. Right now Apache beam supports onlysetup.pyinstallation and we are planning to move toPEP 517, 518->pyproject.tomlbuild process.if someone install from that generated requirements file in a fresh env and do a
pip check, they would get an error sayingtensorboard 2.13.0 requires wheel, which is not installed.The text was updated successfully, but these errors were encountered: