Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loop by default from audio summary. #1061

Merged
merged 1 commit into from Mar 19, 2018

Conversation

svpcoder
Copy link
Contributor

Easier when there are multiple audio samples on a summary page that is user is listening to.

More discussion at:
#296

cc @rryan

Easier when there are multiple audio samples on a summary page that is user is listening to.

More discussion at:
tensorflow#296
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@svpcoder
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@svpcoder svpcoder closed this Mar 18, 2018
@svpcoder svpcoder reopened this Mar 18, 2018
@rryan
Copy link
Member

rryan commented Mar 18, 2018

LGTM, thanks!

Copy link
Member

@chihuahua chihuahua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! And one could right-click any audio element and enable looping for it anyway.

@chihuahua chihuahua merged commit 9fce139 into tensorflow:master Mar 19, 2018
@svpcoder svpcoder deleted the patch-1 branch March 19, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants