Remove Object.values() #1089
Merged
Remove Object.values() #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://caniuse.com/#search=object.value this does not work in IE or Chrome <=49 which is 0.82% of the global population. The Closure Library can solve this problem. See also: https://stackoverflow.com/q/49355552/1653720
chihuahua
approved these changes
Mar 31, 2018
| @@ -400,7 +401,7 @@ <h3>There’s no dashboard by the name of “<tt>[[_selectedDashboard]]</tt>.” | |||
| _dashboardData: { | |||
| type: Array, | |||
| readOnly: true, | |||
| value: Object.values(tf_tensorboard.dashboardRegistry), | |||
| value: goog.object.getValues(tf_tensorboard.dashboardRegistry), | |||
There was a problem hiding this comment.
We can actually just use lodash's _.values method and avoid an import.
That being said, I'm a fan of the Closure library in terms of the multi-browser support, security, and built-in constructs it offers. I'd be up for importing Closure if you think we can make good use of it.
There was a problem hiding this comment.
We can absolutely get value out of the Closure Library.
Lodash is actually blocking us from integrating a stack overflow fix in dagrejs/dagre#228 since the release came included with a Lodash surprise. There's maybe a dozen teams at Alphabet who use Lodash. So we're going to need to roll up our sleeves and use Rosie to migrate their codebases, before we can get the benefits of that fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://caniuse.com/#search=object.value this does not work in IE
or Chrome <=49 which is 0.82% of the global population. The Closure Library can
solve this problem.
See also: https://stackoverflow.com/q/49355552/1653720