-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only display active dashboards #181
Conversation
a3f5600
to
80fafcc
Compare
8c01216
to
3eb3c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some changes requested:
- Keep a list of inactive dashboards, as a dropdown on the right ('5 inactive dashboards') and let user explicitly load it if they want.
- If user puts hash for inactive dashboard, nav to it anyway.
- Make font consistent for the "loading dashboards" message in top bar.
- If we keep the toast, it should be on top not bottom of window.
- Fix the broken logdir test.
80fafcc
to
81212a6
Compare
Thanks for the review! I'll post a comment here when I've addressed each of these.
|
3eb3c5e
to
cf3873d
Compare
cf3873d
to
e68eba6
Compare
Per your request, I've The focus state on the dropdown items is required for a11y. PTAL :-) |
Discussed offline:
|
e68eba6
to
66fd107
Compare
Summary: This commit incorporates the backend's `is_active` plugin functions and the related `plugins_listing` handler, and uses them on the client: we will only display dashboards that correspond to backend plugins that are active. Test Plan: - Launch TensorBoard with a normal data set and note that the correct set of dashboards is displayed. - Launch TensorBoard with a nonexistent or empty logdir and observe the global "no data" message. - Launch TensorBoard and cause the `plugins_listing` network request to fail. (In Chrome: Network devtools tab, right-click the request, select "Block Request URL", refresh.) Note the resulting message. Then, unblock the request, and click TensorBoard's reload button: everything should work as usual. - Launch TensorBoard with a large data set, and open the frontend before it's read any text summaries. Then, click TensorBoard's reload button and note that the "Text" dashboard tab appears and functions. - Launch TensorBoard on a large data set. Select the "text" dashboard. Then, relaunch the TensorBoard backend on the same port, and click the frontend's reload button before any text summaries are loaded. Note that TensorBoard removes the text dashboard and shoves the user over to a different dashboard (the first dashboard loaded) with a notice. - Launch TensorBoard, let it load data, then kill the server and click TensorBoard's reload button. Note that the already-loaded features of TensorBoard are still operational. Also, `bazel run //tensorboard/functionaltests:core_test` and step away from your computer for a minute or so. wchargin-branch: active-dashboards
66fd107
to
a0a939f
Compare
(Last push was just a rebase; no content change.) |
Summary:
This commit incorporates the backend's
is_active
plugin functions andthe related
plugins_listing
handler, and uses them on the client: wewill only display dashboards that correspond to backend plugins that are
active.
Test Plan:
set of dashboards is displayed.
the global "no data" message.
plugins_listing
network requestto fail. (In Chrome: Network devtools tab, right-click the request,
select "Block Request URL", refresh.) Note the resulting message.
Then, unblock the request, and click TensorBoard's reload button:
everything should work as usual.
before it's read any text summaries. Then, click TensorBoard's
reload button and note that the "Text" dashboard tab appears and
functions.
Then, relaunch the TensorBoard backend on the same port, and click
the frontend's reload button before any text summaries are loaded.
Note that TensorBoard removes the text dashboard and shoves the user
over to a different dashboard (the first dashboard loaded) with a
notice.
TensorBoard's reload button. Note that the already-loaded features
of TensorBoard are still operational.
wchargin-branch: active-dashboards