backend: eliminate unnecessary metaprogramming #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This was a relic of a piecewise migration from the `event_accumulator`’s old form to its current `plugin_event_accumulator` form. (See #345 for an example of one of the intermediate states.) Now totally superfluous, it incurs needless cognitive and CPU overhead, as the `getattr` blocks standard optimizations. Test Plan: All tests pass, and TensorBoard can still load the standard demo data. wchargin-branch: eliminate-metaprogramming
stephanwlee
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was a relic of a piecewise migration from the
event_accumulator’sold form to its current
plugin_event_accumulatorform. (See #345 foran example of one of the intermediate states.) Now totally superfluous,
it incurs needless cognitive and CPU overhead, as the
getattrblocksstandard optimizations.
Test Plan:
All tests pass, and TensorBoard can still load the standard demo data.
wchargin-branch: eliminate-metaprogramming