New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slicing buckets in WIT #2704

Merged

jameswex merged 1 commit into tensorflow:master from jameswex:fix_buckets

Sep 28, 2019

Contributor

jameswex commented Sep 27, 2019

Motivation for features / changes

Slicing by numeric features didn't always give the right result.

Technical description of changes

If number of buckets >= number of unique values, don't do ranges, slice by unique values.
In this case, make sure to delete bucket range information.

Detailed steps to verify changes work correctly (as executed by you)

Test in demo crossing the unique value threshold in both directions.


          fix bucketing

aea3a90

googlebot added the cla: yes label

jameswex requested a review from tolga-b

September 27, 2019 19:43

tolga-b approved these changes

View reviewed changes

jameswex merged commit 1d49a25 into tensorflow:master

jameswex deleted the fix_buckets branch

September 28, 2019 00:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment