uploader: export experiments to subdirectories #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We now emit an experiments scalar data to `experiment_123/scalars.json` rather than `scalars_123.json`. This generalizes more cleanly to writing multiple files under an experiment’s directory. Test Plan: Unit tests updated. One previous test case can no longer be hit and has thus been removed. wchargin-branch: uploader-export-subdirs wchargin-source: baa128470c061d7d2c0153f6491a1cdf8dd416c5
wchargin-branch: uploader-export-subdirs wchargin-source: f5009e29cf96dd119b769ad553c5666438f4df99
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Mar 3, 2020
Summary: We now emit an experiment’s scalar data to `experiment_123/scalars.json` rather than `scalars_123.json`. This generalizes more cleanly to writing multiple files under an experiment’s directory. Test Plan: Unit tests updated. One previous test case can no longer be hit and has thus been removed. wchargin-branch: uploader-export-subdirs
Merged
nfelt
pushed a commit
that referenced
this pull request
Mar 4, 2020
Summary: We now emit an experiment’s scalar data to `experiment_123/scalars.json` rather than `scalars_123.json`. This generalizes more cleanly to writing multiple files under an experiment’s directory. Test Plan: Unit tests updated. One previous test case can no longer be hit and has thus been removed. wchargin-branch: uploader-export-subdirs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We now emit an experiment’s scalar data to
experiment_123/scalars.jsonrather than
scalars_123.json. This generalizes more cleanly to writingmultiple files under an experiment’s directory.
Test Plan:
Unit tests updated. One previous test case can no longer be hit and has
thus been removed.
wchargin-branch: uploader-export-subdirs