Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove %tensorflow_version 2.x directives #3459

Merged
merged 10 commits into from Apr 2, 2020

Conversation

ManishAradwad
Copy link
Contributor

Fixes : #3451
@wchargin Plz review this PR

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@wchargin
Copy link
Contributor

wchargin commented Apr 1, 2020

For context, this supersedes #3452.

Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks nearly correct. Could you please merge master to pick
up CI changes and also fix stale outputs (see inlines)?

@@ -90,12 +90,6 @@
}
],
"source": [
"try:\n",
" # %tensorflow_version only exists in Colab.\n",
" %tensorflow_version 2.x\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This output cell is stale, right?

      "outputs": [
        {
          "name": "stdout",
          "output_type": "stream",
          "text": [
            "TensorFlow 2.x selected.\n"
          ]
        }
      ],

Likewise in other notebooks.

Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check is still failing; please run through nbfmt.py.

@wchargin wchargin changed the title Updated notebooks in tensorboard/docs docs: remove %tensorflow_version 1.x directives Apr 2, 2020
@wchargin wchargin changed the title docs: remove %tensorflow_version 1.x directives docs: remove %tensorflow_version 2.x directives Apr 2, 2020
@wchargin wchargin merged commit 6d93158 into tensorflow:master Apr 2, 2020
@wchargin
Copy link
Contributor

wchargin commented Apr 2, 2020

Thanks for the contribution!

@ManishAradwad ManishAradwad deleted the issue#3451 branch April 3, 2020 05:26
bileschi pushed a commit to bileschi/tensorboard that referenced this pull request Apr 15, 2020
Colab now uses TensorFlow 2.x by default, so `%tensorflow_version 2.x`
is no longer required. Fixes tensorflow#3451.
bileschi pushed a commit that referenced this pull request Apr 15, 2020
Colab now uses TensorFlow 2.x by default, so `%tensorflow_version 2.x`
is no longer required. Fixes #3451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need to manually specify version in notebooks
3 participants