diagnose: warn on broken What-If Tool version #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Issues like #3460, #3481, and #3592 are all caused by an incompatibility between certain versions of TensorBoard and the standalone What-If Tool. This patch adds a check to the diagnosis script to warn accordingly. Test Plan: Install `tensorflow==2.1.0 tensorboard-plugin-wit==1.6.0.post2` into a new virtualenv, and note that TensorBoard fails to start. Then run the diagnosis script and note that it prints a suggestion with a command that, when executed, solves the problem. wchargin-branch: diagnose-broken-wit
ericdnielsen
approved these changes
May 6, 2020
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
Summary: Issues like tensorflow#3460, tensorflow#3481, and tensorflow#3592 are all caused by an incompatibility between certain versions of TensorBoard and the standalone What-If Tool. This patch adds a check to the diagnosis script to warn accordingly. Test Plan: Install `tensorflow==2.1.0 tensorboard-plugin-wit==1.6.0.post2` into a new virtualenv, and note that TensorBoard fails to start. Then run the diagnosis script and note that it prints a suggestion with a command that, when executed, solves the problem. wchargin-branch: diagnose-broken-wit
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
Summary: Issues like #3460, #3481, and #3592 are all caused by an incompatibility between certain versions of TensorBoard and the standalone What-If Tool. This patch adds a check to the diagnosis script to warn accordingly. Test Plan: Install `tensorflow==2.1.0 tensorboard-plugin-wit==1.6.0.post2` into a new virtualenv, and note that TensorBoard fails to start. Then run the diagnosis script and note that it prints a suggestion with a command that, when executed, solves the problem. wchargin-branch: diagnose-broken-wit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issues like #3460, #3481, and #3592 are all caused by an incompatibility
between certain versions of TensorBoard and the standalone What-If Tool.
This patch adds a check to the diagnosis script to warn accordingly.
Test Plan:
Install
tensorflow==2.1.0 tensorboard-plugin-wit==1.6.0.post2into anew virtualenv, and note that TensorBoard fails to start. Then run the
diagnosis script and note that it prints a suggestion with a command
that, when executed, solves the problem.
wchargin-branch: diagnose-broken-wit