[Debuggger V1] Remove external reference to the deprecated plugin #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Aug 14, 2020
|
@nickfelt Done. |
psybuzz
approved these changes
Aug 14, 2020
caisq
added a commit
that referenced
this pull request
Aug 15, 2020
* Motivation for features / changes
* This PR removes the Python backend and web frontend code of
the Debugger (V1) plugin. This plugin has been marked as deprecated
and for removal in the 2.3.0 release notes.
* Technical description of changes
* #4033 has removed the reference to this plugin from other parts of TensorBoard.
* This PR in turn removes code in tensorboard/plugins/debugger.
* Detailed steps to verify changes work correctly (as executed by you)
* Verified that Debugger V2 still functions properly
* Internal CL for corresponding code removal is tested globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin has been marked as deprecated and for removal in the 2.3.0
release notes. The code itself will be removed in a follow-up change.
BUILD files, Python modules and Polymer .html files that are not a part of
plugins/debugger.
needed to be fixed (i.e., dependency on the ":metadata" BUILD target added in
each respective BUILD file) after plugins/debugger is removed. This probably was due
to an unmasking of transitive dependencies of some sort.