rust: regenerate build with cargo-raze 0.7.0 #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Version 0.7.0 of `cargo-raze` was just released. Some visible changes:
- can now set `[package.metadata.raze]` instead of `[raze]` to avoid a
Cargo warning: <google/cargo-raze#274>
- build files have been renamed and restructured to be more compliant
with Buildifier: <google/cargo-raze#260>
If you have an old version installed, run `cargo install cargo-raze` to
update to the most recent version.
Changes to `third_party/rust/` generated with:
```
(rm -rf third_party/rust/ && cd tensorboard/data/server && cargo raze)
```
The changes to `Cargo.toml` and `third_party/rust/` are independent.
Test Plan:
Run `(cd tensorboard/data/server && cargo test)` and note that the tests
run without an “unused manifest key: raze” warning. Note further that
everything still builds with Bazel.
wchargin-branch: rust-regen-raze-0.7.0
wchargin-source: c73530a2f7948b4842617ff686f645e66e917d0d
Merged
nfelt
approved these changes
Nov 9, 2020
wchargin-branch: rust-regen-raze-0.7.0 wchargin-source: e9738c8a0faa6b4547ddbd7c5b924eb7377a87e6
wchargin-branch: rust-regen-raze-0.7.0 wchargin-source: e9738c8a0faa6b4547ddbd7c5b924eb7377a87e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Version 0.7.0 of
cargo-razewas just released. Some visible changes:[package.metadata.raze]instead of[raze]to avoid aCargo warning: Accept
[package.metadata.raze], superseding[raze]google/cargo-raze#274with Buildifier: Made generated files more Buildifier compliant google/cargo-raze#260
If you have an old version installed, run
cargo install cargo-razetoupdate to the most recent version.
Changes to
third_party/rust/generated with:The changes to
Cargo.tomlandthird_party/rust/are independent.Test Plan:
Run
(cd tensorboard/data/server && cargo test)and note that the testsrun without an “unused manifest key: raze” warning. Note further that
everything still builds with Bazel.
wchargin-branch: rust-regen-raze-0.7.0