Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing dark mode makes paint dirty #5305

Conversation

JamesHollyer
Copy link
Contributor

@JamesHollyer JamesHollyer commented Sep 9, 2021

This is a fix for issue 5246.

Upon initial change from light to dark mode and dark to light mode the graphs used to look like this:
Screen Shot 2021-09-08 at 9 57 35 PM
Screen Shot 2021-09-08 at 9 57 53 PM

and now they look like this:
Screen Shot 2021-09-08 at 9 54 17 PM
Screen Shot 2021-09-08 at 9 54 10 PM

The problem was that that change from dark to light mode did lot indicate the the SeriesLineView that the lines were "dirty" so upon update it did not realize they needed to be redrawn.

Fixes #5246.

Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great. I did not think this would literally be one line fix. Would you mind taking a look at the test and meaningfully prevent regression or detect a bug? (A possible answer is, it is hard to test this in a way that can prevent any regressions and require more integrational style testing such as one that uses WebDriver).

Also, pro-tip: if you type "Fixes #<ISSUE_NUMBER>.", GitHub will automatically close the issue when you merge the PR (https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests).

Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case testing this is more challenging than adding a few LOC, I am approving the change.

@JamesHollyer JamesHollyer merged commit 23b7685 into tensorflow:master Oct 28, 2021
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error bar color does not change after switching the dark/light mode
2 participants