Time Series: tooltip sort by alphabetical order #5442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japie1235813
force-pushed
the
sort-tooltip
branch
from
a81acc2
to
13d555c
Compare
stephanwlee
reviewed
Nov 30, 2021
| @@ -27,7 +27,7 @@ export enum PluginType { | |||
| // When editing a value of the enum, please write a backward compatible | |||
| // deserializer in data_source/metrics_data_source.ts. | |||
| export enum TooltipSort { | |||
| DEFAULT = 'default', | |||
| ALPHABETICAL = 'Alphabetical', | |||
There was a problem hiding this comment.
ALPHABETICAL = 'alphabetical', for consistency please.
|
Yes, it's preserved in local storage for In new commit I add DEFAULT back and fall to alphabetic when loading the global settings. |
japie1235813
force-pushed
the
sort-tooltip
branch
from
dfd5b72
to
cec1bd9
Compare
stephanwlee
approved these changes
Dec 1, 2021
Comment on lines
378
to
379
| metricsSettings.tooltipSort = TooltipSort.ALPHABETICAL; | ||
| break; |
There was a problem hiding this comment.
alternative: remove these two lines.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
In the list of tooltip sorting method, we replace "default" with "alphabetical". The alphabetical order is based on the display name.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
In the list of tooltip sorting method, we replace "default" with "alphabetical". The alphabetical order is based on the display name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the list of tooltip sorting method, we remove "default" and replace with "alphabetical order". The alphabetical order is based on the display name.